Possible misspelling of function name for changesForModelModication()#1941
Open
sderazo wants to merge 1 commit intoeclipse-pde:masterfrom
Open
Possible misspelling of function name for changesForModelModication()#1941sderazo wants to merge 1 commit intoeclipse-pde:masterfrom
sderazo wants to merge 1 commit intoeclipse-pde:masterfrom
Conversation
gireeshpunathil
approved these changes
Aug 22, 2025
Test Results 618 files ±0 618 suites ±0 49m 23s ⏱️ - 5m 47s For more details on these failures, see this check. Results for commit ed7ee34. ± Comparison against base commit d9ad053. |
The change from changesForModelModication() to changesForModelModification() (originally declared in the PDEModelUtility.java file) is being made to improve the coding and debugging experience for developers. One of the parameters that this function takes in is final ModelModification modification, which makes me think that Modication should be Modification instead. This would help save time with debugging since when I was working on Issue 1813, I saw that there was an error message with the function and I could not figure out what was wrong until I saw that I misspelled the function by one letter.
laeubi
force-pushed
the
correct-spelling
branch
from
ed7ee34 to
5614632
Compare
laeubi
approved these changes
Jan 17, 2026
Contributor
laeubi
left a comment
laeubi
left a comment
There was a problem hiding this comment.
Only internal so change looks fine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The change from changesForModelModication() to changesForModelModification() (originally declared in the PDEModelUtility.java file) is being made to improve the coding and debugging experience for developers. One of the parameters that this function takes in is final ModelModification modification, which makes me think that Modication should be Modification instead. This would help save time with debugging since when I was working on Issue 1813, I saw that there was an error message with the function and I could not figure out what was wrong until I saw that I misspelled the function by one letter.